Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 4.13: add control property (#5943) #5944

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Cherry-pick to 4.13: add control property (#5943) #5944

merged 1 commit into from
Oct 29, 2021

Conversation

EricDahlvang
Copy link
Member

  • add control property

  • disable fragile test

#minor

@johnataylor @EricDahlvang
add control property (#5943)
bc26bdb 
* add control property

* disable fragile test
@EricDahlvang EricDahlvang requested review from a team as code owners October 29, 2021 21:10
@EricDahlvang EricDahlvang merged commit aa95898 into 4.13 Oct 29, 2021
@EricDahlvang EricDahlvang deleted the eric/cherryPickLGFix branch October 29, 2021 21:26
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 275096

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 78.678%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.LanguageGeneration/Evaluator.cs 6 95.21%
/libraries/Microsoft.Bot.Builder.LanguageGeneration/Templates.cs 9 96.27%
/libraries/Microsoft.Bot.Builder.LanguageGeneration/Expander.cs 34 70.87%
Totals Coverage Status
Change from base Build 263794: 0.05%
Covered Lines: 18063
Relevant Lines: 22958
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic Stevenic was automatically assigned from microsoft/bf-adaptive

@chrimc62 chrimc62 Awaiting requested review from chrimc62 chrimc62 was automatically assigned from microsoft/bf-adaptive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricDahlvang @coveralls @johnataylor